[wp-trac] [WordPress Trac] #39516: Media grid upload errors display below the grid.

WordPress Trac noreply at wordpress.org
Sun Feb 19 21:30:05 UTC 2017


#39516: Media grid upload errors display below the grid.
------------------------------+--------------------------------------------
 Reporter:  joemcgill         |       Owner:  afercia
     Type:  defect (bug)      |      Status:  assigned
 Priority:  normal            |   Milestone:  4.7.3
Component:  Media             |     Version:  4.6
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  ui, accessibility, javascript
------------------------------+--------------------------------------------
Changes (by joemcgill):

 * keywords:  has-patch needs-testing needs-refresh => has-patch commit


Comment:

 @afercia good catch on the missed build.

 I missed the use of `this.options.sidebar` earlier, and on second thought
 we should probably check that `this.options.sidebar` is not falsey before
 trying to render the sidebar anyway, so [attachment:39516.3.diff] is good.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39516#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list