[wp-trac] [WordPress Trac] #39814: wp_usermeta uses umeta_id instead of meta_id

WordPress Trac noreply at wordpress.org
Mon Feb 13 04:02:56 UTC 2017


#39814: wp_usermeta uses umeta_id instead of meta_id
--------------------------------------------+------------------------------
 Reporter:  johnjamesjacoby                 |       Owner:
     Type:  defect (bug)                    |      Status:  new
 Priority:  normal                          |   Milestone:  Awaiting Review
Component:  Database                        |     Version:  0.71
 Severity:  normal                          |  Resolution:
 Keywords:  2nd-opinion dev-feedback close  |     Focuses:
--------------------------------------------+------------------------------
Changes (by dd32):

 * keywords:  2nd-opinion dev-feedback => 2nd-opinion dev-feedback close


Comment:

 In an ideal world everything would be named consistently - but it's not,
 instead we put consistent API's in front of it so that others shouldn't
 need worry about these small nuances.

 I don't think we should be changing anything here, definitely not renaming
 the column, as it potentially breaks compatibility while not actually
 gaining much (code already exists to work around the name difference). We
 could work around queries using the old column name - but doing so doesn't
 seem worth it.

 If there's any locations in the meta api where we return the key
 `umeta_id` and `meta_id` in other cases, then updating it so as to cause
 usermeta to return `[umeta_id => ..., meta_id => ..., ...]` would seem
 sane - once again, so as to add a consistent API.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39814#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list