[wp-trac] [WordPress Trac] #35126: Improvements for the new .button-link CSS class

[WordPress Trac]

#35126: Improvements for the new .button-link CSS class
----------------------------+--------------------------------
 Reporter:  afercia         |       Owner:  Cheffheid
     Type:  enhancement     |      Status:  assigned
 Priority:  normal          |   Milestone:  4.8
Component:  Administration  |     Version:  4.4
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  ui, accessibility
----------------------------+--------------------------------
Changes (by afercia):

 * keywords:  has-patch needs-testing 2nd-opinion => has-patch
 * milestone:  Future Release => 4.8


Comment:

 Refreshed patch builds on the previous ones, with some adjustments
 discussed with @Cheffheid.

 Quoting the conversation on Slack linked above, the consensus was about:
 > it's way simpler to just update ⁠⁠⁠⁠button-link⁠⁠⁠⁠ adding color and
 underline, then modifier classes for red links etc.

 In [attachment:35126.diff] the base class just makes a button look like a
 regular link and then it can use modifiers as stackable classes, in the
 same way all the WP buttons CSS classes work. For example, `button-link
 button-link-delete` makes a button link red.

 In a few places, some button-links will be now underlined. I'd say it's
 not too bad and seems more consistent to me, see screenshots below.
 Special places to check:
 - Customizer
 - Media Views
 - Press This: I've removed some `button-link` classes since they were
 mainly used to reset the buttons.

 Worth noting `button-link` was never intended as a "button reset" and
 shouldn't be used that way. There's probably the need for a `button-reset`
 specific class, but I'd say that's material for a separate ticket.

 Moving to 4.8.

 [[Image(https://cldup.com/xKHexm5CH1.png)]]

 [[Image(https://cldup.com/GOSTB0v3Ld.png)]]

 [[Image(https://cldup.com/ZFqFa7wi1W.png)]]

 [[Image(https://cldup.com/aXDwRnuQgY.png)]]

 [[Image(https://cldup.com/Ym1WXtrOuY.png)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35126#comment:40>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform