[wp-trac] [WordPress Trac] #38778: Only show video header controls if previewing front page

[WordPress Trac]

#38778: Only show video header controls if previewing front page
--------------------------+------------------
 Reporter:  westonruter   |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.7
Component:  Customize     |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+------------------

Comment (by flixos90):

 Replying to [comment:3 westonruter]:
 > @flixos90 I don't think `is_header_video_active()` is relevant? The
 `active_callback` in the patch controls whether or not the controls are
 shown or not. You wouldn't want to use `is_header_video_active()` as the
 `active_callback` because then you'd never be able to access the control
 to set the header video.

 I think you're talking about `has_header_video()`. The function
 `is_header_video_active()` checks (via theme support) for which areas of
 the theme the header video is supported at all, as we decided that there
 might be themes that want to display the video elsewhere, not only on the
 front page. It would be a replacement for all the currently hardcoded
 `is_front_page()` checks, so I think it would need to be used here as
 well.
 But like I said earlier, the name of that function is yet to be
 determined, so this should just act as a reminder of the other ticket.
 Whatever is committed first, the other one has to be adjusted accordingly.
 So you might not even have to worry about it at this point. :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38778#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform