[wp-trac] [WordPress Trac] #36904: Add caching to comment feed in WP_Query

[WordPress Trac]

#36904: Add caching to comment feed in WP_Query
----------------------------------------+-----------------------------
 Reporter:  spacedmonkey                |       Owner:
     Type:  enhancement                 |      Status:  new
 Priority:  normal                      |   Milestone:  Future Release
Component:  Query                       |     Version:  2.2
 Severity:  normal                      |  Resolution:
 Keywords:  needs-unit-tests has-patch  |     Focuses:  performance
----------------------------------------+-----------------------------

Comment (by boonebgorges):

 >  The biggest changed the wp_comment_query isn't called twice now. Is now
 only called after post_results have been setup.

 Thanks. This is a step in the right direction. However, it won't work for
 values of `fields` like `ids` or `id=>parent`. I'm not sure if there are
 other ramifications for moving the comment query, so this needs some
 examination. As noted above, unit tests will be critical to prevent
 against regressions.

 > The value of the 'comment_feed_where' will be different from before, but
 I am not sure of how much of an issue this is.

 A good first step here is to search the plugin repo to see who is using
 this filter, and for what.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36904#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform