[wp-trac] [WordPress Trac] #37470: Shiny Updates: Erroneous Plugin Deactivation

[WordPress Trac]

#37470: Shiny Updates: Erroneous Plugin Deactivation
----------------------------+------------------------------
 Reporter:  voldemortensen  |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  Plugins         |     Version:  4.2.4
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:
----------------------------+------------------------------
Changes (by swissspidy):

 * component:  General => Plugins


Comment:

 Are you sure this wasn't reproducible prior to 4.2? Plus, how is it caused
 by Shiny Updates V1 and not by something else?

 I was once playing with the idea of changing the main plugin file and IIRC
 @ipstenu and @otto42 said it's a bad idea. And it's understandable: The
 list of active plugins (e.g. `woocommerce/woocommerce.php` and so on) is
 stored in the options table. If an active plugin file is missing, the
 plugin will be deactivated.

 That means if you're ever going to do such a change, you would need to
 keep the old plugin file for BC reasons. In it, you could add a migration
 script that changes the `active_plugins` option to include the new plugin
 file instead of the old one. Problem solved.

 I've seen a few plugins changing the plugin name in an upgrade without
 such a migration part, which is a bad idea.

 Perhaps we could change something about this in core, i.e. check if
 there's a new one in the same folder if the main plugin file is missing,
 but otherwise it's probably a documentation/education issue.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37470#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform