[wp-trac] [WordPress Trac] #35941: Eliminate WP_Customize_Site_Logo_Control

[WordPress Trac]

#35941: Eliminate WP_Customize_Site_Logo_Control
------------------------------+--------------------
 Reporter:  celloexpressions  |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  4.5
Component:  Customize         |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+--------------------
Changes (by celloexpressions):

 * keywords:  needs-patch => has-patch


Comment:

 [attachment:35941.diff] eliminates the unnecessary
 `WP_Customize_Site_Logo_Control`. Note that there are no UI changes
 whatsoever (once #35542 is also committed). For developers/the customizer
 API, this clarifies that `WP_Customize_Media_Control` should be used for
 basic media such as image controls that don't require specialized UI for a
 specific purpose.

 The patch also adds two changes that benefit core beyond this cleanup:
 - All of the media controls now send media attachment information to the
 preview when a new file is selected, facilitating the use of postMessage
 setting transport without additional ajax calls or custom controls.
 - There was a double-bottom-margin on all the media controls that I
 noticed when cleaning up the CSS; this is now removed so that the intended
 rhythm of control spacing is maintained (by using the margin on the
 control, and removing the excessive one on the last element within the
 control).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35941#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform