[wp-trac] [WordPress Trac] #35912: Allow changing network URL scheme

[WordPress Trac]

#35912: Allow changing network URL scheme
-----------------------------------+------------------------------
 Reporter:  rmccue                 |       Owner:
     Type:  enhancement            |      Status:  new
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  Networks and Sites     |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:  multisite
-----------------------------------+------------------------------

Comment (by rmccue):

 Replying to [comment:3 BinaryKitten]:
 > could the option be available to switch schema for any site (maybe in
 site edit?)

 You can already edit the URL here for any non-main site; after this patch,
 the scheme will be editable for all sites, rather than just non-main
 sites.

 Replying to [comment:5 johnjamesjacoby]:
 > I have a hunch we can't get away with this as easily as the first patch
 suggests. I'm thinking of places like site-search that use the root domain
 & path for relative site look-ups. Are there any other places (maybe the
 `by_path()` functions) where this would allow outright breaking of things
 without warning?

 Neither `get_site_by_path()` or `get_network_by_path()` use the scheme; I
 can't think of any other lookups that would vary based on the scheme. I
 ''think'' it's reasonably safe to update.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35912#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform