[wp-trac] [WordPress Trac] #25247: WP_Dependencies unsets a to do item when it isn't loaded

WordPress Trac noreply at wordpress.org
Sat Feb 20 15:55:03 UTC 2016


#25247: WP_Dependencies unsets a to do item when it isn't loaded
-------------------------------------------------+-------------------------
 Reporter:  markoheijnen                         |       Owner:  chriscct7
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  Future
Component:  Script Loader                        |  Release
 Severity:  normal                               |     Version:  3.6
 Keywords:  has-patch needs-testing has-unit-    |  Resolution:
  tests                                          |     Focuses:
-------------------------------------------------+-------------------------
Changes (by ocean90):

 * keywords:  has-patch dev-feedback needs-testing has-unit-tests => has-
     patch needs-testing has-unit-tests


Comment:

 @gitlost Thanks! So let's ignore the scripts part for now.
 I've removed the change to `unset( $this->to_do[$key] );` and the tests
 are still passing. Is this change still necessary? If yes, we need a test
 which fails before the change.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/25247#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list