[wp-trac] [WordPress Trac] #32075: Only set WP_MAX_MEMORY_LIMIT by default when its greater than memory_limit

WordPress Trac noreply at wordpress.org
Sat Feb 13 16:31:39 UTC 2016


#32075: Only set WP_MAX_MEMORY_LIMIT by default when its greater than memory_limit
------------------------------------+-----------------------------
 Reporter:  danielbachhuber         |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  Future Release
Component:  Bootstrap/Load          |     Version:  3.2
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+-----------------------------

Comment (by DrewAPicture):

 @markoheijnen I think the switch block is fine, especially if new contexts
 ever get added. I also agree on adding a default, but if one of the two
 cases in the switch uses the default `sdmin` context, then perhaps the
 combine the default with the case.

 @jrf In the DocBlocks, the summaries should use third-person singular
 verbs and should be a summary, rather than a title. So just remove "WP
 raise memory limit" and promote "Raises the PHP memory limit for memory
 intensive processes." to the top as the summary.

 Also, if you pass `--no-prefix` when you generate your git diffs, it won't
 print out all your personal information in the patch ;-)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32075#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list