[wp-trac] [WordPress Trac] #35804: Add post type to the oEmbed iframe 'title' attribute

WordPress Trac noreply at wordpress.org
Fri Feb 12 12:13:18 UTC 2016


#35804: Add post type to the oEmbed iframe 'title' attribute
--------------------------+-----------------------------
 Reporter:  ramiy         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Embeds        |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  accessibility
--------------------------+-----------------------------
Changes (by swissspidy):

 * keywords:  has-patch => needs-patch
 * focuses:   => accessibility
 * milestone:  Awaiting Review => Future Release


Comment:

 For reference, to understand why this attribute is even there:

 https://github.com/swissspidy/oEmbed-API/issues/42
 https://github.com/swissspidy/oEmbed-API/pull/121

 Citing @johnbillion:

 > I think "Embedded WordPress Post" isn't an accurate representation of
 the iframe's contents. The site's title should be used instead. I'll do a
 new PR.

 A new PR was never submitted, so this likely was missed.

 I'm more in favour of using the site title instead of `Embedded WordPress
 %s`. First, because it's more representative and some likely don't want to
 see "WordPress" in there.

 Second, `Embedded WordPress %s` needs to be translated differently
 depending on the post type. For example, in German page is female while
 post is male. This means the string would need to be added to post type
 labels, which I don't really want to do. See also #14981.

 I'd suggest something along the lines of "Embedded content from xy".

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35804#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list