[wp-trac] [WordPress Trac] #38995: Twenty Seventeen: Custom headers incorrect on mobile when no image is set.

[WordPress Trac]

#38995: Twenty Seventeen: Custom headers incorrect on mobile when no image is set.
---------------------------+------------------------
 Reporter:  joemcgill      |       Owner:  joemcgill
     Type:  defect (bug)   |      Status:  accepted
 Priority:  normal         |   Milestone:  4.7
Component:  Bundled Theme  |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+------------------------

Comment (by davidakennedy):

 Nice patch, @laurelfulford! And thanks @anariel-design for the additional
 report and thoughts!

 I tested this patch and it works well. We talked about going this route in
 Slack yesterday, and even though it's a lot of small changes, it makes the
 most sense because the theme needs to account for its appearance when
 there is/isn't an image/video ''and'' when there is a video but no image.
 It's best to separate everything out as Laurel has done to make everything
 easier to understand and work with. This patch looks good to go to me.

 I'm good with making the changes to adjust the file name, container`div`
 name and class `.custom-header-image`. It makes more sense in a world of
 both header images and header videos. But this wouldn't be absolutely
 necessary... If we want to do it, it needs to be done now because that
 can't be changed in future releases. I'm curious what others think?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38995#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform