[wp-trac] [WordPress Trac] #36658: Adding method to reset the mocked phpmailer instance

WordPress Trac noreply at wordpress.org
Sat Apr 30 13:38:57 UTC 2016


#36658: Adding method to reset the mocked phpmailer instance
------------------------------+------------------
 Reporter:  welcher           |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  4.6
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  needs-patch       |     Focuses:
------------------------------+------------------
Changes (by boonebgorges):

 * keywords:  has-patch dev-feedback => needs-patch


Comment:

 The reset method looks good to me.

 I think the `tests_` prefix on the function is meant to be a namespace -
 see `tests_add_filter()`. I am wary of changing it just for aesthetic
 reasons, as there may be third-party libraries using it. Could you change
 it back and post an updated patch?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36658#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list