[wp-trac] [WordPress Trac] #36666: Enhance `remove_theme_support()` so that it can take additional arguments

WordPress Trac noreply at wordpress.org
Wed Apr 27 13:30:19 UTC 2016


#36666: Enhance `remove_theme_support()` so that it can take additional arguments
------------------------------------+------------------------------
 Reporter:  flixos90                |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Themes                  |     Version:  3.0
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+------------------------------

Comment (by jmichaelward):

 Replying to [comment:10 flixos90]:
 > Also, when removing a specific element from support produces an empty
 array as result, the theme feature is removed entirely. I assume we don't
 want to have something like `$_wp_theme_features['post-formats'][0] =
 array()`.

 This is definitely something we'll want to check for, and I had overlooked
 this in my update to #22080 as well.

 > @jmichaelward Feel free to review and enhance the updated patch. Also,
 can you ensure that you upload a full diff for upcoming patches please,
 not only a diff from the file you patched? It is much easier to handle.

 Will do. This is only my third ticket and I don't yet have a lot of
 experience working with Subversion, so it's not always clear to me when to
 patch a single file (since that's all I've been editing), or when to patch
 everything. I've been working from
 [https://make.wordpress.org/core/handbook/tutorials/trac/submitting-a-patch/
 this article]. Should I just be ignoring step one and patching everything
 instead?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36666#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list