[wp-trac] [WordPress Trac] #28352: New filters in wp-activate.php

WordPress Trac noreply at wordpress.org
Thu Apr 21 04:00:50 UTC 2016


#28352: New filters in wp-activate.php
------------------------------------+------------------------
 Reporter:  UmeshSingla             |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  4.6
Component:  Login and Registration  |     Version:  3.0
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch               |     Focuses:  multisite
------------------------------------+------------------------

Comment (by boonebgorges):

 A couple questions about the patch:

 - Is there a way it can be restructured so we're not passing so much
 markup to the filters? The answer here may well be "no", but it would be
 nice to minimize it, since it makes the filter very difficult to use for
 any purpose but completely rebuilding the message.

 - The two different kinds of string being filtered through
 'signup_activation_error' are not similar at all. Only the second one
 seems like an error at all. Given the multiple different ways these
 messages can be built, I would lean toward having a single
 'signup_activation_message' filter that everything gets passed through;
 callbacks can determine whether it's an "error" by looking at the
 `$result` parameter.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28352#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list