[wp-trac] [WordPress Trac] #36392: wp_add_inline_script() breaks script dependency order when using script loader (no SCRIPT_DEBUG)

WordPress Trac noreply at wordpress.org
Sun Apr 10 03:07:08 UTC 2016


#36392: wp_add_inline_script() breaks script dependency order when using script
loader (no SCRIPT_DEBUG)
---------------------------------------------+-------------------------
 Reporter:  westonruter                      |       Owner:  swissspidy
     Type:  defect (bug)                     |      Status:  assigned
 Priority:  high                             |   Milestone:  4.5
Component:  Script Loader                    |     Version:  trunk
 Severity:  major                            |  Resolution:
 Keywords:  has-unit-tests has-patch commit  |     Focuses:
---------------------------------------------+-------------------------
Changes (by jeremyfelt):

 * keywords:  has-unit-tests has-patch => has-unit-tests has-patch commit


Comment:

 [attachment:36392.2.diff] looks good to me as well.
 [attachment:36392.3.diff] is the exact same except for an additional test
 that accounts for the case of mixed concat/non-concat for core scripts
 when scripts one and two are standard and the third script has an inline
 script before. This works as expected.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36392#comment:37>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list