[wp-trac] [WordPress Trac] #36424: graphically visualize if comments are closed (in wp-admin/edit.php)

WordPress Trac noreply at wordpress.org
Sat Apr 9 10:47:11 UTC 2016


#36424: graphically visualize if comments are closed (in wp-admin/edit.php)
----------------------------+---------------------------------
 Reporter:  pixelverbieger  |       Owner:
     Type:  enhancement     |      Status:  new
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  Comments        |     Version:
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:  ui, administration
----------------------------+---------------------------------

Comment (by Presskopp):

 I had a night to think about it. What if there is at least 1 comment AND
 comments are closed. Do we show the 'comments closed' sign or do we show
 the bubble with the number? Or both??

 The other thing is the line for screen reader - "Comments are closed."
 seems to be the standard throwout in this case inside WP and not just
 "Comments closed".
 I'm not sure about if a new line for translation is needed here, or if it
 gets done when we use "Comments are closed" - and what about the dot at
 the end of the string? "Comments are closed." Is it needed or not?

 This is showing the lock only when there also are no comments:

 {{{#!php
                 // Comments are closed, show a lock then - Translation
 needed
                 if ( ! comments_open( $post_id ) && ( ! wp_count_comments(
 $post_id ))) {
                         printf( '<span aria-hidden="true"><span
 class="dashicons dashicons-lock"></span></span><span class="screen-reader-
 text">%s</span>',
                                 __( 'Comments are closed' )
                         );
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36424#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list