[wp-trac] [WordPress Trac] #36412: Custom Logo: Not able to "Skip Cropping" or crop non-square from small images.

[WordPress Trac]

#36412: Custom Logo: Not able to "Skip Cropping" or crop non-square from small
images.
-------------------------------------------------+-------------------------
 Reporter:  mikeschroder                         |       Owner:  obenland
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.5
Component:  Customize                            |     Version:  trunk
 Severity:  major                                |  Resolution:
 Keywords:  has-patch dev-feedback needs-        |     Focuses:  javascript
  testing                                        |
-------------------------------------------------+-------------------------

Comment (by mikeschroder):

 For my testing so far, @adamsilverstein's [attachment:36412.diff] appears
 to function as expected, although given my unfamiliarity with the code,
 unsure if it's possible to do in a simpler manner or not (further up in
 the chain). As many eyes on it as possible would be appreciated.

 @westonruter's [attachment:36412.mustBeCropped.diff] fixes the other half
 of the bug reported in this ticket, and is pretty straight-forward.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36412#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform