[wp-trac] [WordPress Trac] #36412: Custom Logo: Not able to "Skip Cropping" or crop non-square from small images.

[WordPress Trac]

#36412: Custom Logo: Not able to "Skip Cropping" or crop non-square from small
images.
-------------------------------------------------+-------------------------
 Reporter:  mikeschroder                         |       Owner:  obenland
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.5
Component:  Customize                            |     Version:  trunk
 Severity:  major                                |  Resolution:
 Keywords:  has-patch dev-feedback needs-        |     Focuses:  javascript
  testing                                        |
-------------------------------------------------+-------------------------

Comment (by obenland):

 Replying to [comment:17 azaozz]:
 > So the fix here is to add a skip button and add `'flex-width' => true`
 to the theme.

 I'm afraid it's not that easy. Themes should be able to allow only one
 side to be flexible. While I haven't tested @adamsilverstein's patch yet,
 from the screenshot it looks like that is the way to go. The skip button
 is also a nice addition, but not a fix to the bug.

 As I said in Slack, when either side is flexible we should allow arbitrary
 size/aspect ​''selections''. That selection would then be downsized to the
 specified dst hight/width, whichever is not flexible.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36412#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform