[wp-trac] [WordPress Trac] #36412: Custom Logo: Not able to "Skip Cropping" or crop non-square from small images.

[WordPress Trac]

#36412: Custom Logo: Not able to "Skip Cropping" or crop non-square from small
images.
-------------------------------------------------+-------------------------
 Reporter:  mikeschroder                         |       Owner:  obenland
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.5
Component:  Customize                            |     Version:  trunk
 Severity:  major                                |  Resolution:
 Keywords:  has-patch dev-feedback needs-        |     Focuses:  javascript
  testing                                        |
-------------------------------------------------+-------------------------

Comment (by azaozz):

 > what is the drawback of allowing both to be flexible when a theme
 accommodates a logo with any aspect ratio.

 No drawback, just the theme should be able to accept "weird" sizes :) We
 can work on this more in 4.6 and perhaps add some limitations or overrides
 like 36412.diff (thinking now is too late for that).

 Having a skip button is nice too. If arbitrary size is allowed, the whole
 image will be scaled.

 After all this is part of the customizer. If the users chooses "unusual"
 image (too narrow or too tall) they will be able to see it doesn't look
 right straight away :)

 So the fix here is to add a skip button and add `'flex-width' => true` to
 the theme.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36412#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform