[wp-trac] [WordPress Trac] #36412: Custom Logo: Not able "Skip Cropping" or crop non-square from small images.

[WordPress Trac]

#36412: Custom Logo: Not able "Skip Cropping" or crop non-square from small images.
--------------------------+-------------------------
 Reporter:  mikeschroder  |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  4.5
Component:  Customize     |    Version:  trunk
 Severity:  major         |   Keywords:  needs-patch
  Focuses:  javascript    |
--------------------------+-------------------------
 While working on the About page, @melchoyce ran into this:
 https://cloudup.com/cJjq9VEjgVP

 Uploading the (file to be shortly attached) small logo, the user is unable
 to make it wider, or select entire image, even though this aspect ratio is
 okay for the theme.

 This looks to happen in both Twenty Fifteen and Twenty Sixteen.

 Some notes from @obenland:
 > "It seems like there are still issues with the image cropper
 > - Images that are smaller than the desired width or height get magnified
 > - Images that are larger than the desired width or height but don’t pass
 `mustBeCropped()` can’t be > resized but actually have to be cut
 >
 > When one side is flexible, the entire image should be selectable so that
 it can be sized down.
 > ...
 > With that paradigm you can never scale down an image that is wider than
 the desired size of the fixed side.
 > ...
 > [Skip cropping button is] missed because it determines it has to be
 cropped
 > The `mustBeCropped()` method in `wp-admin/js/customize-controls.js` does
 the determination

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36412>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform