[wp-trac] [WordPress Trac] #36389: Selective refresh for widgets gets lost once `refresh` is used

WordPress Trac noreply at wordpress.org
Mon Apr 4 03:42:00 UTC 2016


#36389: Selective refresh for widgets gets lost once `refresh` is used
--------------------------------------+--------------------------
 Reporter:  scamartist26              |       Owner:  westonruter
     Type:  defect (bug)              |      Status:  accepted
 Priority:  normal                    |   Milestone:  4.5
Component:  Customize                 |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+--------------------------
Changes (by westonruter):

 * keywords:  has-patch => has-patch has-unit-tests


Comment:

 I've added unit tests for this issue in [attachment:36389.2.diff]. Adding
 unit tests also necessitated introducing a static
 `WP_Customize_Setting::reset_aggregated_multidimensionals()` to reset the
 protected static `$aggregated_multidimensionals` variable after each test.
 (In hindsight, it may have been better to store the
 `$aggregated_multidimensionals` as a non-static variable on
 `WP_Customize_Manager` so that it would be cleaned up automatically after
 the manager is destructed.)

 Unit tests are running on a PR: https://github.com/xwp/wordpress-
 develop/pull/149

 +1 for commit for RC2?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36389#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list