[wp-trac] [WordPress Trac] #33699: Hidden password input fields should default to disabled="disabled"

[WordPress Trac]

#33699: Hidden password input fields should default to disabled="disabled"
--------------------------+---------------------------------------------
 Reporter:  raamdev       |       Owner:  adamsilverstein
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  Future Release
Component:  Users         |     Version:  4.3
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  ui, javascript, administration
--------------------------+---------------------------------------------

Comment (by adamsilverstein):

 Ok @JasWSInc thanks for the feedback and confirming this fixes the issue.

 I will work up a patch with the disabled attribute applied. Happy to add
 that if it resolves the issue! I use chrome password manager but never
 seem to have this issue - i wonder if my settings are different somehow?
 any special steps to reproduce?




 Replying to [comment:3 JasWSInc]:
 >     Can you give the steps to reproduce and/or try adding
 disabled="disabled" attribute to all the hidden fields, including the
 generated one, to see if it helps.
 >
 > I can confirm that adding `disabled="disabled"` resolves this in Chrome,
 Firefox, and Opera. Adding `disabled="disabled"` seems the way to go! :-)
 Any field that is not being displayed should be disabled to avoid this
 conflict. That way any attempt to auto-fill a field (by whatever software;
 e.g., Chrome, LastPass, etc.) will have no adverse effect. ''Note that a
 field that is disabled (even if POSTd) will not be sent to the server.
 That's exactly what we need in this scenario.''

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33699#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform