[wp-trac] [WordPress Trac] #33501: Starting w/ WP4.2, upgrade scenario may fail for non-MySQL installs

[WordPress Trac]

#33501: Starting w/ WP4.2, upgrade scenario may fail for non-MySQL installs
------------------------------------------+---------------------
 Reporter:  RSkoon                        |       Owner:  pento
     Type:  defect (bug)                  |      Status:  closed
 Priority:  normal                        |   Milestone:  4.4
Component:  Database                      |     Version:  4.1.2
 Severity:  normal                        |  Resolution:  fixed
 Keywords:  needs-patch needs-unit-tests  |     Focuses:
------------------------------------------+---------------------
Changes (by pento):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"34655"]:
 {{{
 #!CommitTicketReference repository="" revision="34655"
 WPDB: Make sure we don't run sanity checks on DB dropins.

 Previously, we'd run the sanity checks if `is_mysql` was not set to
 `false`. This caused problems for DB drop-ins that didn't define
 `is_mysql` at all. Instead, we can just check if `is_mysql` is `empty()`.

 Also fix some unit tests that accidently ran correctly because of the
 strict `false ===` comparison.

 Fixes #33501.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33501#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform