[wp-trac] [WordPress Trac] #34025: Improve method documentation for WP_Widget_Search

WordPress Trac noreply at wordpress.org
Sat Sep 26 17:26:58 UTC 2015


#34025: Improve method documentation for WP_Widget_Search
----------------------------------------+-----------------------
 Reporter:  DrewAPicture                |       Owner:  leemon
     Type:  defect (bug)                |      Status:  assigned
 Priority:  normal                      |   Milestone:  4.4
Component:  Widgets                     |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  good-first-bug needs-patch  |     Focuses:  docs
----------------------------------------+-----------------------
Changes (by DrewAPicture):

 * keywords:  good-first-bug has-patch => good-first-bug needs-patch
 * owner:   => leemon
 * status:  new => assigned


Comment:

 Hi @leemon,

 Thanks for the patch!

 As mentioned in [comment:3:ticket:34027 #34027]:

 > Just a couple of notes:
 >
 > * Let's go with the vernacular of something like "the current {type}
 widget instance" instead of "a particular instance of a widget". Being
 general in the `WP_Widget` base class is fine, but in this context, we can
 be more specific. For example:
 >
 > {{{
 >  * Handles updating settings for the current Text widget instance.
 > }}}
 >
 > * Notice I inserted the type of widget, in this case "Text", and more
 specifically mentioned updating the ''settings'' which is what the
 `update()` method does.
 > * The same sort of advice goes along with any other method in the class.
 The idea is to avoid simple copy pasta and actually get specific :-)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34025#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list