[wp-trac] [WordPress Trac] #33735: Reduce Duplication and Improve Comment Notification Email Functions

WordPress Trac noreply at wordpress.org
Tue Sep 15 06:13:52 UTC 2015


#33735: Reduce Duplication and Improve Comment Notification Email Functions
--------------------------------------+------------------------------
 Reporter:  dshanske                  |       Owner:
     Type:  enhancement               |      Status:  new
 Priority:  low                       |   Milestone:  Awaiting Review
Component:  Mail                      |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+------------------------------

Comment (by kitchin):

 Great. Notes:

 * Any reason you're passing $comment_id instead of $comment ?

 * Can delete `$comment_author_domain =
 @gethostbyaddr($comment->comment_author_IP);` at 14346 and 1570 in the old
 code.

 * Need to sprintify `$notify_message .= __( 'You can see all comments on
 this post here:' ) . "\r\n";`

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33735#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list