[wp-trac] [WordPress Trac] #33867: Unit tests to protect against breaking pluggable function changes

[WordPress Trac]

#33867: Unit tests to protect against breaking pluggable function changes
------------------------------+------------------
 Reporter:  johnbillion       |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  4.4
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+------------------

Comment (by adamsilverstein):

 This is a great idea John, thanks!.

 I tested locally and verified the test fail when i changed a pluggable
 function parameter signature.

 What do you think about adding @group pluggable to the header? I added
 this to help me run just these tests and notice we already have some tests
 in this group. Added in [attachment:33867.2.patch].


 Replying to [comment:1 johnbillion]:
 > Any of the following changes will cause the tests in
 [attachment:33867.patch] to fail:
 >
 >  * Renaming a pluggable function parameter.
 >  * Changing, adding, or removing the default value of a pluggable
 function parameter.
 >  * Deleting a pluggable function, or moving it outside of pluggable.php.
 >  * Adding a new pluggable function.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33867#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform