[wp-trac] [WordPress Trac] #33023: _get_custom_object_labels should not change data type to Array from Object.

[WordPress Trac]

#33023: _get_custom_object_labels should not change data type to Array from Object.
-------------------------------+------------------------------
 Reporter:  zsiteru            |       Owner:  wonderboymusic
     Type:  defect (bug)       |      Status:  closed
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Posts, Post Types  |     Version:  4.2.2
 Severity:  normal             |  Resolution:  fixed
 Keywords:  has-patch          |     Focuses:
-------------------------------+------------------------------
Changes (by wonderboymusic):

 * owner:   => wonderboymusic
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"34102"]:
 {{{
 #!CommitTicketReference repository="" revision="34102"
 Objects are passed by-reference since PHP 5. In
 `_get_custom_object_labels()`, cast `$object->labels` back to `object`
 before returning. This function is weird.

 Adds unit test.

 Props Toro_Unit.
 Fixes #33023.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33023#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform