[wp-trac] [WordPress Trac] #33819: #a11y-headings - Add Themes

[WordPress Trac]

#33819: #a11y-headings - Add Themes
----------------------------+------------------------------
 Reporter:  Cheffheid       |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  Administration  |     Version:  4.3
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:  accessibility
----------------------------+------------------------------

Comment (by afercia):

 I'd say this screen is maybe one of the most complicated and has a few
 issues worth discussing, as @Cheffheid pointed out.

 1. '''Feature Filter:''' I'd say each feature group should be a
 `<fieldset>` and so the current `h4` are perfect candidates to be the
 fieldsets legend. Also, I don't see the need to have the feature group
 marked up as an ordered list.
 2. '''Themes list:''' what I see here is a... list. Would be appropriate
 to use a list (maybe a definition list `<dl>`?). I understand this would
 require to rework many things (PHP and JS templates) so maybe we could
 just switch the `<h3>` to `<h2>` for now.
 3. '''The hidden "Add New Theme" h2:''' as far as I see it's added via
 JavaScript and only needed in the "Installed Themes" screen. Here it's
 hidden but maybe, to be a bit more clean, we should avoid to inject it
 just checking for `! themes.isInstall` in `/wp-admin/js/theme.js`
 4. '''The h3 added when a theme is selected for preview:''' as far as I
 see it's the theme name in the preview overlay. In my opinion, if we want
 to consider the preview overlay like a "full-size modal" we should make
 sure to hide all the other content from assistive technologies and then
 the preview would be the only content available; at this point this
 heading should be a `h1` as done in (almost) all the other admin modals.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33819#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform