[wp-trac] [WordPress Trac] #33620: When creating a new subdirectory site, scheme is always set to http

[WordPress Trac]

#33620: When creating a new subdirectory site, scheme is always set to http
--------------------------------+------------------------------
 Reporter:  johnbillion         |       Owner:
     Type:  defect (bug)        |      Status:  new
 Priority:  normal              |   Milestone:  Awaiting Review
Component:  Networks and Sites  |     Version:
 Severity:  normal              |  Resolution:
 Keywords:  needs-patch         |     Focuses:  multisite
--------------------------------+------------------------------

Comment (by thomaswm):

 Replying to [comment:1 johnbillion]:
 > This is blocked by #33041

 I wonder why `install_blog()` calls `get_blogaddress_by_id()` to retrieve
 the path and domain from the database when they could have just as easily
 been passed to `install_blog()` as function parameters. They are stored as
 variables in `wpmu_create_blog()` but they aren't passed on to
 `install_blog()`.

 [https://core.trac.wordpress.org/browser/tags/4.3/src/wp-includes/ms-
 functions.php#L1161 Line 1161] in `wp-includes/ms-functions.php` would
 have to be changed to


 {{{
 install_blog($blog_id, $title, $scheme, $domain, $path);
 }}}
 and then the call to `get_blogaddress_by_id()` would be obsolete.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33620#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform