[wp-trac] [WordPress Trac] #33199: Admin Menu Items Break

[WordPress Trac]

#33199: Admin Menu Items Break
-------------------------------------+---------------------------------
 Reporter:  atomicjack               |       Owner:
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  4.3.1
Component:  Administration           |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui, administration
-------------------------------------+---------------------------------
Changes (by atomicjack):

 * keywords:  has-patch => has-patch needs-testing


Comment:

 Replying to [comment:57 johnjamesjacoby]:
 > Replying to [comment:56 atomicjack]:
 > > what's the actual problem it is going to cause if it is limited to
 just the sidebar of the wp-admin?
 >
 > Good question. Here's what I can think of:
 >
 > * To start, z-indexes should be tested (in places like the customizer
 and media modals, off the top of my head) to ensure menu sub-navigation
 doesn't overlap them.
 > * Then, the scroll-spy style movement of the menu needs to be confirmed
 that it's still working, and working smoothly.
 > * Next, browser testing should confirm this fix doesn't break something
 else (I don't think that it will, in my experience with this.)
 > * Finally, bundled scripts that create pop-ups or modals (jQuery UI
 Datepicker, et all) should be tested to confirm they don't react
 differently to this new rendering, painting, & positioning.

 Thanks for pointing out specific areas of concern.

 I'll test some of those now and report back shortly.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33199#comment:58>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform