[wp-trac] [WordPress Trac] #33621: If FORCE_SSL_ADMIN is true, the scheme of the siteurl option should reflect this

[WordPress Trac]

#33621: If FORCE_SSL_ADMIN is true, the scheme of the siteurl option should reflect
this
--------------------------------------+------------------------------
 Reporter:  johnbillion               |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Administration            |     Version:  3.0
 Severity:  normal                    |  Resolution:
 Keywords:  needs-patch dev-feedback  |     Focuses:
--------------------------------------+------------------------------

Old description:

> When `FORCE_SSL_ADMIN` is defined and set to true, the "Site Address
> (URL)" option on the General Settings screen still shows an `http` scheme
> unless the site was installed over `https` or the scheme was manually
> changed.
>
> The `siteurl` option should either be filtered to show an `https` scheme,
> or be corrected to have an `https` scheme when the option is saved.

New description:

 When `FORCE_SSL_ADMIN` is defined and set to true, the "WordPress Address
 (URL)" option on the General Settings screen still shows an `http` scheme
 unless the site was installed over `https` or the scheme was manually
 changed.

 The `siteurl` option should either be filtered to show an `https` scheme,
 or be corrected to have an `https` scheme when the option is saved.

--

Comment (by johnbillion):

 Just realised that I typo'd the field name in the ticket description.
 `siteurl` is represented by the "WordPress Address" field, not the "Site
 Address" field (yay naming).

 Replying to [comment:6 peterwilsoncc]:
 > Changing the value on save could confuse the user for no reason,
 especially if they expect home & site URLs to match.

 Why would a user expect the URLs to match if `FORCE_SSL_ADMIN` is set to
 true but their home URL uses `http`? Displaying the incorrect scheme is
 the confusing behaviour.

 Related: [28674]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33621#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform