[wp-trac] [WordPress Trac] #33643: Merge similar strings - failed to upload

[WordPress Trac]

#33643: Merge similar strings - failed to upload
--------------------------+-----------------------------
 Reporter:  pavelevap     |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  I18N          |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+-----------------------------

Comment (by swissspidy):

 Replying to [comment:4 juhise]:
 > Replying to [comment:3 pavelevap]:
 > > There are many other strings with full stop, see "Upload stopped.",
 "File canceled.", "%s exceeds the maximum upload size for this site." and
 others. I only wanted to merge similar strings and avoid other discussion
 about related issues, because it would never be committed :-)
 >
 > Yeah, But this string also didn't have full stop previously, So it would
 be great if we only remove the extra text (as suggest by you) and not add
 full stop. :)

 But the other similar string has a full stop: `“%s” has failed
 to upload.`

 This ticket is about making these strings the ''same'', so both should
 have either a full stop or none. Considering the first string has had a
 full stop before, [attachment:33643.patch 33643.patch] makes more sense to
 me.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33643#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform