[wp-trac] [WordPress Trac] #28510: Split javascript files in media into modules

[WordPress Trac]

#28510: Split javascript files in media into modules
----------------------------+-----------------------------
 Reporter:  ericlewis       |       Owner:  wonderboymusic
     Type:  task (blessed)  |      Status:  reopened
 Priority:  normal          |   Milestone:  4.2
Component:  Media           |     Version:  3.5
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  javascript
----------------------------+-----------------------------

Comment (by wonderboymusic):

 In [changeset:"31935"]:
 {{{
 #!CommitTicketReference repository="" revision="31935"
 Let us pray to the gods of backwards compatibility:

 * The way that the JS modules for media are currently set up turns the
 existing global `wp.media` namespace into a read-only API, this is bad.
 * For the existing module implementation to work with plugins, those
 looking to override or extend a class would have to modify their own
 plugin to use `browserify` - we can't expect this to happen
 * Because the general way that plugins override media classes is via
 machete (resetting them to something else), we cannot use `require(
 'module' )` in the internal code for media modules

 We CAN continue to use `require( 'fun/js' )` in the manifests for media.

 Future code/projects should carefully consider what is made to be public
 API. In 3.5, EVERYTHING was made public, so everything shall remain
 public.

 See #31684, #28510.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28510#comment:38>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform