[wp-trac] [WordPress Trac] #31669: views improvements continued

WordPress Trac noreply at wordpress.org
Mon Mar 30 22:15:53 UTC 2015


#31669: views improvements continued
--------------------------+-------------------------
 Reporter:  iseulde       |       Owner:  azaozz
     Type:  defect (bug)  |      Status:  reviewing
 Priority:  normal        |   Milestone:  4.2
Component:  TinyMCE       |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  javascript
--------------------------+-------------------------

Comment (by mattheu):

 This breaks the the core AV view.

 [[Image(https://dl.dropboxusercontent.com/s/747b7mhefdiaoyd/2015-03-30%20at%2023.11%202x.png?dl=0)]]

 Looks like this happend in 31669.11.patch.

 <code>head = editor.getDoc().getElementsByTagName( 'head' )[0]</code>

 Firstly - I think this should be set to the value of innerHTML.
 Secondly - The value of head is always overridden. I think that if this is
 neccessary it should check whether this has been set already or not.

 Adding a patch.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31669#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list