[wp-trac] [WordPress Trac] #31791: Customizer Theme Switcher: Switch the details/live preview buttons

WordPress Trac noreply at wordpress.org
Fri Mar 27 22:48:41 UTC 2015


#31791: Customizer Theme Switcher: Switch the details/live preview buttons
------------------------------+--------------------
 Reporter:  celloexpressions  |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  4.2
Component:  Customize         |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:  ui
------------------------------+--------------------

Comment (by westonruter):

 Replying to [comment:3 afercia]:
 > @celloexpression hi, quick question: any reason to use a span instead of
 a real button?
 > {{{
 > <span class="button" tabindex="0" id="{{ data.theme.id }}-action"><?php
 _e( 'Theme Details' ); ?></span>
 > }}}
 > did't test the patch though, just reading the code. As a best practice,
 we should always use elements that have native support for keyboard
 interaction. Thanks :)

 Adding `tabindex` to any element makes it keyboard-interactable.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31791#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list