[wp-trac] [WordPress Trac] #31575: Press This: post options toggle accessibility improvements

[WordPress Trac]

#31575: Press This: post options toggle accessibility improvements
------------------------------+--------------------------------------------
 Reporter:  afercia           |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Press This        |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch dev-    |     Focuses:  ui, accessibility, javascript
  feedback                    |
------------------------------+--------------------------------------------

Comment (by azaozz):

 Replying to [comment:6 stephdau]:

 Don't think this approach is good. Currently we have two buttons and two
 simple JS functions to handle open/close. This is all pretty simple, easy
 to read, understand, etc. Why should we switch to one complex "dynamic"
 button with many spans in it and one combined JS function that is longer
 and harder to read than the two? Also "toggle" usually implies we don't
 care of the current state much, just want to change it. That's not true in
 this case though :)

 If the word "Done" is not enough for screen readers, lets add the "Close
 post options" screen-reader-text there too. Moving the `aria-expanded` to
 the panel makes sense. Don't thing it should be on the button as well...

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31575#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform