[wp-trac] [WordPress Trac] #31763: Do quote user selection when dealing with an oembed provider's site.

WordPress Trac noreply at wordpress.org
Wed Mar 25 16:11:47 UTC 2015


#31763: Do quote user selection when dealing with an oembed provider's site.
--------------------------+------------------------------------
 Reporter:  stephdau      |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  4.2
Component:  Press This    |    Version:  trunk
 Severity:  normal        |   Keywords:  has-patch dev-feedback
  Focuses:                |
--------------------------+------------------------------------
 We recently (#31637) made the decision to not blockquote text underneath
 embeds, when the source site is recognized as an oembed provider (Youtube,
 SoundCloud, etc).

 This works when we discover a page's description (Open Graph tags, etc),
 but we should probably quote the text if the user went to the extent of
 actually selecting some in the source page (`s` in `$_POST` or `$_GET`).

 The attached patch does this. We should also discuss if when we do so, we
 should also include the standard attribution link, as we do for other
 cases. I'd argue it's not necessary, since the embeds all have direct
 links to the source, but I'm opened to it.

 I'm listing this as a bug because we didn't discuss it at the time, but it
 came up as an expectation when [https://wordpress.slack.com/archives/core-
 pressthis/p1427294820000002 brought up].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31763>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list