[wp-trac] [WordPress Trac] #31723: is_page( false ) === true ?

WordPress Trac noreply at wordpress.org
Sun Mar 22 10:53:34 UTC 2015


#31723: is_page( false ) === true ?
--------------------------+------------------------------
 Reporter:  Compute       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Query         |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------------------

Comment (by jipmoors):

 Replying to [comment:2 valendesigns]:
 > Unfortunately, if we were to make that simple change and return `false`
 then 36 tests fail. I do agree that it seems wrong that it would return
 `true` in these situations, but doing anything about it would require a
 lot of refactoring of tests and could have wide sweeping backwards
 compatibility implications. I'm inclined to close as `wontfix` because of
 it.

 I disagree, a simple modification on the default value would solve this
 problem.
 The way it is set up now is pretty ugly and can simply be improved upon by
 setting the default to null. This will keep all the tests passing and
 prevents bad data from being entered.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31723#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list