[wp-trac] [WordPress Trac] #31726: Thickbox add wrongly &random param to URL for videos

[WordPress Trac]

#31726: Thickbox add wrongly &random param to URL for videos
---------------------------+-----------------------------
 Reporter:  thomask        |      Owner:
     Type:  defect (bug)   |     Status:  new
 Priority:  normal         |  Milestone:  Awaiting Review
Component:  Script Loader  |    Version:  4.1.1
 Severity:  normal         |   Keywords:
  Focuses:                 |
---------------------------+-----------------------------
 This seems to be a very old unnoticed bug of thickbox, e.g. see
 https://wordpress.org/support/topic/plugin-wp-table-reloaded-display-data-
 from-other-database?replies=21#post-2510147,
 http://forum.opencart.com/viewtopic.php?f=10&t=6116,
 http://www.houseoffusion.com/groups/jquery/thread.cfm/threadid:1947

 under some cirmutances, it appends "&random=some_random_number" to the
 attachment URL, but the problem is, it ads this even if the URL do not
 have any ?param before it, so it results in nonexisting page. I have
 noticed this when i add thickbox to a href for mp4 videos, and the
 resulting url was /wp-content/uploads/myvideofile.mp4&random=12345

 The problem is on line 234 of thickbox.js

 {{{
 jQuery("#TB_ajaxContent").load(url += "&random=" + (new
 Date().getTime()),function(){//to do a post change this load method
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31726>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform