[wp-trac] [WordPress Trac] #31701: Emoji: Avoid enqueueing JS by default

WordPress Trac noreply at wordpress.org
Fri Mar 20 22:09:29 UTC 2015


#31701: Emoji: Avoid enqueueing JS by default
-----------------------------+--------------------------------------
 Reporter:  obenland         |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  4.2
Component:  General          |     Version:  trunk
 Severity:  major            |  Resolution:
 Keywords:  emoji has-patch  |     Focuses:  javascript, performance
-----------------------------+--------------------------------------

Comment (by pento):

 Replying to [comment:11 wonderboymusic]:
 > Every time `wp_print_scripts/styles()` runs, we are going to run this
 JS? This feels strange.

 Nice catch. :-) [attachment:31701.3.diff] adds a static flag to the
 functions, so they're only ever printed once.

 > I'm all for smilies, but are they really this important?

 Not just smilies, they're //emoji//.

 > What if I never want this code to run, do I have to add a filter every
 time I fire up a WordPress project?

 Yep.

 > This code makes sense for WordPress.com and Jetpack, I get it, but this
 seems weird to me as base product code.

 This goes back to some of the [https://make.wordpress.org/core/2015/02/13
 /emoji-chat-meeting-notes-february-12-2015/ original discussion] of emoji.
 The issue now is how to provide consistent emoji support for everyone.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31701#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list