[wp-trac] [WordPress Trac] #23931: wp_insert_comment should require comment_post_ID

WordPress Trac noreply at wordpress.org
Thu Mar 19 07:15:23 UTC 2015


#23931: wp_insert_comment should require comment_post_ID
--------------------------------------------------+------------------
 Reporter:  markoheijnen                          |       Owner:
     Type:  defect (bug)                          |      Status:  new
 Priority:  normal                                |   Milestone:  4.2
Component:  Comments                              |     Version:  2.0
 Severity:  normal                                |  Resolution:
 Keywords:  has-patch needs-testing dev-feedback  |     Focuses:
--------------------------------------------------+------------------
Changes (by valendesigns):

 * keywords:  has-patch needs-refresh => has-patch needs-testing dev-
               feedback


Comment:

 I've refreshed the patch, but there were some test failures that needed to
 be addressed after the update. 3 tests failed due to a `WP_Error` being
 returned and 1 failed asserting that an array is not empty, because you
 can't create a comment without a `comment_post_ID` anymore. I added the ID
 and all tests pass again.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/23931#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list