[wp-trac] [WordPress Trac] #31532: Shiny Updates: Don't activate plugins with PHP errors

[WordPress Trac]

#31532: Shiny Updates: Don't activate plugins with PHP errors
-----------------------------+---------------------------------------------
 Reporter:  pento            |       Owner:  pento
     Type:  task (blessed)   |      Status:  assigned
 Priority:  normal           |   Milestone:  4.2
Component:  Upgrade/Install  |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  shiny-updates    |     Focuses:  ui, javascript, administration
  has-patch                  |
-----------------------------+---------------------------------------------

Comment (by pento):

 [attachment:31532.2.diff] was a little experiment, but I don't think it's
 viable. After a plugin has been updated, it does another HTTP request,
 this time to `plugin-install.php`. It parses the menu HTML out of it, and
 sends that back, so we can automatically update the menu.

 It doesn't work for a few reasons:
 * It doesn't include any new CSS added, so menus with custom icons end up
 with a blank icon.
 * The menu hover handler doesn't work once the menu is refreshed.
 * Plugins that do a redirect on activate cause the new menu to have the
 wrong menu item marked as currently active.

 Oh, and there's also the problem of it being dependant on us not changing
 the wp-admin HTML.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31532#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform