[wp-trac] [WordPress Trac] #31242: Global Emoji Support

WordPress Trac noreply at wordpress.org
Mon Mar 16 02:11:07 UTC 2015


#31242: Global Emoji Support
----------------------------+-------------------------
 Reporter:  pento           |       Owner:  pento
     Type:  task (blessed)  |      Status:  assigned
 Priority:  normal          |   Milestone:  4.2
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  javascript
----------------------------+-------------------------

Comment (by pento):

 Replying to [comment:61 DrewAPicture]:
 > @pento: Can we come up with more descriptive names for `feed_emoji()`
 and `mail_emoji()`? I don't feel like they really fit with core style in
 that it's not immediately obvious what purpose they serve. Perhspa
 something like `convert_feed_emoji()` and `convert_mail_emoji()`?

 For you, @DrewAPicture, we can absolutely do that.

 If we want to chat about purpose before deciding on a name, it's worth
 considering that they're really just single-purpose filters (to be thin
 wrappers that filter content through `wp_staticize_emoji()`), so maybe
 they're better as `_`-prefixed `@ignore`-d functions?

 Perhaps `_wp_staticize_emoji_for_email()` and
 `_wp_staticize_emoji_for_feeds()`?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31242#comment:63>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list