[wp-trac] [WordPress Trac] #31527: Bundled themes: Add ARIA attributes to menu toggle

[WordPress Trac]

#31527: Bundled themes: Add ARIA attributes to menu toggle
----------------------------------------------+----------------------------
 Reporter:  davidakennedy                     |       Owner:
     Type:  enhancement                       |      Status:  new
 Priority:  normal                            |   Milestone:  4.2
Component:  Bundled Theme                     |     Version:  4.1
 Severity:  normal                            |  Resolution:
 Keywords:  4.2-beta has-patch needs-testing  |     Focuses:  accessibility
----------------------------------------------+----------------------------

Comment (by davidakennedy):

 Replying to [comment:14 lancewillett]:
 > Patches attached for Twenty Fourteen and Thirteen -- testing and code
 review appreciated. :)

 Thanks for getting these in! They're close, but they need a bit more work.

 In Twenty Thirteen:

 * the `aria-expanded` attribute isn't changing to `true` and back when the
 menu is toggled.
 * the `aria-controls` attribute should correspond with the id of the
 container being expanded, do either the `div` with a class of `nav-menu`
 or the `ul` inside of that `div`.

 Same in Twenty Fourteen:

 * the `aria-expanded` attribute isn't changing to `true` and back when the
 menu is toggled.
 * the `aria-controls` attribute should correspond with the id of the
 container being expanded, do either the `div` with a class of `nav-menu`
 or the `ul` inside of that `div`.
 * We could also add `aria-expanded` and `aria-controls` to the search
 toggle. The difference is that it would always be there since it's always
 a toggle.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31527#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform