[wp-trac] [WordPress Trac] #31484: Widgets in Customizer during theme preview fail to preview widgets with prior sidebars_widgets theme mod and fail to apply upon activation

WordPress Trac noreply at wordpress.org
Sun Mar 8 03:53:17 UTC 2015


#31484: Widgets in Customizer during theme preview fail to preview widgets with
prior sidebars_widgets theme mod and fail to apply upon activation
------------------------------------+-------------------------
 Reporter:  westonruter             |       Owner:  ocean90
     Type:  defect (bug)            |      Status:  assigned
 Priority:  normal                  |   Milestone:  4.1.2
Component:  Customize               |     Version:  4.1
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  javascript
------------------------------------+-------------------------
Changes (by westonruter):

 * keywords:  has-patch => has-patch dev-feedback


Comment:

 OK, that was hard. Unit tests for theme switch in Customizer have been
 added.

 Additional changes:

 * Use object cache instead of static var for
 `WP_Theme::get_allowed_on_network()` and
 `WP_Theme::get_allowed_on_site()`. This allows unit test to update the
 allowed themes.
 * Include `$_REQUEST` in `WP_UnitTestCase::clean_up_global_scope()`
 * Add `test_override_sidebars_widgets_for_theme_switch` and
 `test_override_sidebars_widgets_for_non_theme_switch`
 * Add `$options` param to `WP_Customize_Manager::save()` to bypass Ajax-
 specific behaviors
 * Introduce new `customize_save_before_switch_theme` action instead of
 having WP look at Ajax-specific action `wp_ajax_customize_save`
 * Test saving the customizer and ensuring the new theme and old theme have
 expected states

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31484#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list