[wp-trac] [WordPress Trac] #30666: Add a comment to RTL and minified files for new contributors

WordPress Trac noreply at wordpress.org
Mon Mar 2 06:03:59 UTC 2015


#30666: Add a comment to RTL and minified files for new contributors
-------------------------------------------+-------------------
 Reporter:  SergeyBiryukov                 |       Owner:
     Type:  enhancement                    |      Status:  new
 Priority:  normal                         |   Milestone:  4.2
Component:  Build/Test Tools               |     Version:
 Severity:  normal                         |  Resolution:
 Keywords:  dev-feedback has-patch commit  |     Focuses:  docs
-------------------------------------------+-------------------

Comment (by nacin):

 This duplicates a lot of file paths across tasks. I think there are some
 things we can do to make this a bit simpler. I normally wouldn't slow down
 a ticket, but this is a pretty big increase to the maintenance costs of
 this file.

 I would remove "please do not patch" entirely. Someone looking at this
 file is not likely to be a potential contributor. We shouldn't be implying
 that you can hack away at the non-auto-gen files as a user. Instead, I'd
 just go for something simple like `/*! This file is automatically
 generated. */`. If a contributor can't figure out to not patch said file,
 then I'm not really sure how many more cues we could give them.

 When these files are sucked into load-scripts.php and load-styles.php, I
 surmise there will be repeated "This file is auto generated" throughout.
 Probably not ideal, though matters little.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30666#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list