[wp-trac] [WordPress Trac] #32152: List table: Comments column accessibility improvements

[WordPress Trac]

#32152: List table: Comments column accessibility improvements
--------------------------+--------------------------------
 Reporter:  afercia       |       Owner:  afercia
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.3
Component:  Comments      |     Version:  4.2
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  ui, accessibility
--------------------------+--------------------------------
Changes (by helen):

 * keywords:  has-patch ui-feedback => needs-patch


Comment:

 I like this a lot, though it exposes the comment count ordering is weird
 (#32953). Patch comments:

 * The pending circle should come after the approved comments bubble in the
 markup/output. The tab order feels strange otherwise. I imagine this will
 take some CSS tweaking :)
 * Move the opening strong tag to where the rest of the output is.
 * The contents of the new media query block in the CSS should go into the
 existing media query block, since it's related to what's already in there
 and will help us avoid potential cascade issues as time goes on.
 * Don't do comparisons against `$*_comments_number` since that's a
 translated value. Use the originals instead.
 * Since the various `$*_output` strings are used only once, let's just
 output them where they're used. I haven't traced it all the way yet, but
 even the two different `$no_comments_output` strings should probably just
 be output when needed and those later conditionals for output consolidated
 and made more clear for the future. I missed that it was two different
 sets of if statements while I was reviewing.
 * There are some whitespace issues, and for any single line conditionals
 that are affected, please add braces while we're here.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32152#comment:53>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform