[wp-trac] [WordPress Trac] #35051: Remove title attributes: the Network Themes list table

WordPress Trac noreply at wordpress.org
Sun Dec 13 21:57:41 UTC 2015


#35051: Remove title attributes: the Network Themes list table
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:  afercia
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  4.5
Component:  Networks and Sites       |     Version:  4.4
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots has-     |     Focuses:  ui, accessibility,
  patch commit                       |  multisite
-------------------------------------+-------------------------------------
Changes (by afercia):

 * keywords:  has-screenshots has-patch => has-screenshots has-patch commit


Comment:

 Refreshed patch. As @jeremyfelt pointed out, the check for
 `$this->is_site_themes` is still necessary when editing sites in the
 "Themes" tab. Thus, also the `aria-label` should provide a double text to
 be used for "Enable" or "Network Enable".
 Also, uses `$theme->display( 'Name' )` instead of `$theme->get( 'Name' )`.

 Would appreciate a final review :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35051#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list