[wp-trac] [WordPress Trac] #35047: Notices are not moved to first header when header-elements are nested inside .wrap

WordPress Trac noreply at wordpress.org
Sun Dec 13 09:59:00 UTC 2015


#35047: Notices are not moved to first header when header-elements are nested
inside .wrap
----------------------------+-----------------------------
 Reporter:  DvanKooten      |      Owner:
     Type:  defect (bug)    |     Status:  new
 Priority:  normal          |  Milestone:  Awaiting Review
Component:  Administration  |    Version:  trunk
 Severity:  normal          |   Keywords:
  Focuses:  ui, javascript  |
----------------------------+-----------------------------
 Since [35238], notices are no longer inserted after the first header '''if
 this header is nested'''.

 It is not uncommon for plugins to wrap the entire settings page in some
 kind of grid. In those cases, the first heading on that page is not a
 direct child of the `.wrap` element, resulting in the notices appearing at
 the far top of the page.

 I propose to use `find()` instead of `children()`, as this uses the first
 heading on the page no matter its depth. This used to be the case before
 [35238] as well (`.wrap h2:first`).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35047>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list